Skip to content

Added FESpaces qualifier#193

Merged
JordiManyer merged 1 commit into
gridap:masterfrom
miguelmaso:added-qualifier
Mar 9, 2026
Merged

Added FESpaces qualifier#193
JordiManyer merged 1 commit into
gridap:masterfrom
miguelmaso:added-qualifier

Conversation

@miguelmaso
Copy link
Copy Markdown
Contributor

@miguelmaso miguelmaso commented Mar 9, 2026

Hi, thanks for maintaining the ecosystem of packages related to Gridap!

When using Gridap and related packages (Julia 1.12 and 1.13), I've seen the compilation warning

┌ GridapDistributed
│  WARNING: Constructor for type "FESpace" was extended in `GridapDistributed` without explicit qualification or import.
│    NOTE: Assumed "FESpace" refers to `<null>.FESpace`. This behavior is deprecated and may differ in future versions.
│    NOTE: This behavior may have differed in Julia versions prior to 1.12.
│    Hint: If you intended to create a new generic function of the same name, use `function FESpace end`.
│    Hint: To silence the warning, qualify `FESpace` as `<null>.FESpace` in the method signature or explicitly `import <null>: FESpace`.
└

This PR explicitly qualifies/imports FESpace to avoid the warning. Please let me know if this is the preferred approach. Hope it helps

@JordiManyer
Copy link
Copy Markdown
Member

JordiManyer commented Mar 9, 2026

Huh, I wonder how long that has been there... I guess I should upgrade to Julia 1.12. Thank you for the catch!

@JordiManyer JordiManyer merged commit a61d24b into gridap:master Mar 9, 2026
2 of 3 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (b0e49ea) to head (50886c1).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/DivConformingFESpaces.jl 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##           master    #193   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          15      15           
  Lines        4230    4230           
======================================
  Misses       4230    4230
Flag Coverage Δ
sequential 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@miguelmaso miguelmaso deleted the added-qualifier branch March 10, 2026 07:52
@miguelmaso miguelmaso mentioned this pull request Mar 10, 2026
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miguelmaso @JordiManyer